Skip to content

Add rootPosition to Tasty reflect #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2018
Merged

Add rootPosition to Tasty reflect #4859

merged 1 commit into from
Jul 30, 2018

Conversation

nicolasstucki
Copy link
Contributor

Fixes the two existing source macros and allow the
implementation of Minitest fromContext macro.

@nicolasstucki
Add rootPosition to Tasty reflect
1d82c2d 
Fixes the two existing source macros and allow the
implementation of Minitest fromContext macro.
@nicolasstucki nicolasstucki requested a review from liufengyun July 28, 2018 09:25
@nicolasstucki nicolasstucki added this to the 0.10 Tech Preview milestone Jul 28, 2018
liufengyun
liufengyun approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 896598a into scala:master Jul 30, 2018
@allanrenucci allanrenucci deleted the fix-position-macros branch July 30, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
0.10 Tech Preview
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun